Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Set up Kaniko to cache npm dependencies and ngcc build #289

Merged
merged 2 commits into from
May 26, 2020
Merged

[CI] Set up Kaniko to cache npm dependencies and ngcc build #289

merged 2 commits into from
May 26, 2020

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented May 19, 2020 •
edited
Loading

Closes #283.

Reduces time to build and test from 8-15 min down to about 3.

@gino-m gino-m force-pushed the gcb-cache branch 26 times, most recently from e3086d0 to c4bea39 Compare May 20, 2020 03:15
@gino-m gino-m changed the title [WIP] Testing Kaniko [WIP] Set up Kaniko to cache npm dependencies May 20, 2020
@gino-m gino-m mentioned this pull request May 20, 2020
Open
@gino-m gino-m force-pushed the gcb-cache branch 2 times, most recently from 610e486 to e5db423 Compare May 25, 2020 18:20
@gino-m gino-m force-pushed the gcb-cache branch 8 times, most recently from 9206559 to d2be694 Compare May 25, 2020 20:45
@gino-m gino-m marked this pull request as ready for review May 25, 2020 21:45
@gino-m gino-m requested a review from shobhitagarwal1612 May 25, 2020 21:45
@gino-m gino-m changed the title [WIP] Set up Kaniko to cache npm dependencies [WIP] Set up Kaniko to cache npm dependencies and ngcc build May 25, 2020
@gino-m gino-m changed the title [WIP] Set up Kaniko to cache npm dependencies and ngcc build [CI] Set up Kaniko to cache npm dependencies and ngcc build May 25, 2020
@gino-m
Copy link
Collaborator Author

gino-m commented May 26, 2020

Build CI is currently broken, so force merging this as admin. @shobhitagarwal1612 please still take a look and I can make any changes retroactively!

@gino-m gino-m merged commit cfbdff1 into google:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobhitagarwal1612 shobhitagarwal1612 Awaiting requested review from shobhitagarwal1612

Assignees

@shobhitagarwal1612 shobhitagarwal1612

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Cache npm dependencies to speed up build and test time
2 participants
@gino-m @shobhitagarwal1612